Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164871044
Why not just implement `unhandledFilters`
`https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala#L247`?
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164927780
@marmbrus I saw that Jira ticket. I though It looked for internal
datsources guys agree with using Spark side filter as it is.
I found this problem from
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164942750
Actually, we might still need such function even after adding
`unhandledFilters` although the logics are a bit modified because it woould
still pass all tests even
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164949840
Fair enough, I guess we can probably commit this as is and do the
improvement in another PR.
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164950156
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164996803
Thanks!
I filed the issue about the implementation of `unhandledFilter` here
https://issues.apache.org/jira/browse/SPARK-12354.
---
If your project is set up
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164628074
Can't merge it, but we could ask @marmbrus or @liancheng to take a look if
they have the bandwidth.
---
If your project is set up for it, you can reply to this email
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164563368
This looks reasonable to me, although I'm a bit confused by the addition of
some similar code in https://github.com/apache/spark/pull/9687 - it seems just
having a
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164585973
Oh yes. That is the eventual plan. I will share that function. I opended
some PRs before they are closed. So, I ended up with adding the same function
to another
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-164586872
@holdenk Actually, would you merge this PR if it looks good?
Four other PRs are having a bit of troubles like you just said and I would
like to correct them as
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-163861353
@liancheng Would you like to look through this? it is related with the
filter tests.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-163159813
**[Test build #47418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47418/consoleFull)**
for PR 10221 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-163159981
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-163159983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10221#issuecomment-163143964
**[Test build #47418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47418/consoleFull)**
for PR 10221 at commit
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/10221
[SPARK-12236][SQL] JDBC filter tests all pass if filters are not really
pushed down
https://issues.apache.org/jira/browse/SPARK-12236
Currently JDBC filters are not tested properly. All
17 matches
Mail list logo
