Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170479156
Yeah the original comment was helpful, though it also kind of led me to
believe the setting was connected to the class existing in the public API. That
bit would have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170332485
I'm going to merge this to fix the issue; @vanzin maybe you can swoop in
and double-check what I did here to make sure the `provided` vs `compile` scope
for Guava is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170410974
The fix is correct; that shouldn't have been removed in the first place
(sorry I missed that). The change in that pom is so that the files actually get
packaged
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170247768
Yeah I think this is correct. The comment that was here previously
suggested this was related to use of `Optional` in the public API, but I think
it needs to stay in
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170230870
I'm not sure about that; I believe Guava is supposed to be `provided` here.
Does it fix the issue though? @vanzin how is this one supposed to work re:
shading now that
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170238716
Yes, it does. I'm using the latest revision + the change. It's a serious
issue since standalone Master cannot be started as of today.
I do not know how
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/10674
[SPARK-12736][CORE][DEPLOY] Standalone Master cannot be started due tâ¦
â¦o NoClassDefFoundError: org/spark-project/guava/collect/Maps
/cc @srowen @rxin
You can merge this pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170228387
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170267761
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10674#discussion_r49266568
--- Diff: network/common/pom.xml ---
@@ -55,6 +55,7 @@
com.google.guava
guava
+ compile
--- End diff --
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170269614
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170269616
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/10674#discussion_r49266731
--- Diff: network/common/pom.xml ---
@@ -55,6 +55,7 @@
com.google.guava
guava
+ compile
--- End diff --
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170269576
**[Test build #49047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49047/consoleFull)**
for PR 10674 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170268730
**[Test build #49047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49047/consoleFull)**
for PR 10674 at commit
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170268746
I'm using the following commands to do the build:
```
$ ./dev/change-scala-version.sh 2.11
$ ./build/mvn -Pyarn -Phadoop-2.6
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10674#issuecomment-170268121
@jaceklaskowski, to help me understand the scope of this bug could you tell
us how you built Spark in your failing example? Did you use the Maven or SBT
builds?
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10674#discussion_r49270677
--- Diff: network/common/pom.xml ---
@@ -55,6 +55,7 @@
com.google.guava
guava
+ compile
--- End diff --
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10674#discussion_r49270748
--- Diff: network/common/pom.xml ---
@@ -55,6 +55,7 @@
com.google.guava
guava
+ compile
--- End diff --
20 matches
Mail list logo
