Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219715492
Merged to master/branch-2.0. Thanks @sethah @zhengruifeng for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219617189
@MLnick I made changes accordingly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219477393
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219477391
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219477268
**[Test build #58645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58645/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219475008
**[Test build #58645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58645/consoleFull)**
for PR 12788 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219358645
A few other minor comments, otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63314348
--- Diff: docs/ml-clustering.md ---
@@ -148,5 +148,89 @@ Refer to the [Python API
docs](api/python/pyspark.ml.html#pyspark.ml.clustering.
{%
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63314255
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219357741
@wangmiao1981 could you resolve merge conflicts by rebasing to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-219315029
ping @MLnick @sethah @zhengruifeng @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218960679
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218960680
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218960609
**[Test build #58546 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58546/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218959613
**[Test build #58546 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58546/consoleFull)**
for PR 12788 at commit
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63126914
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63126939
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63126885
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125817
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63126132
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaGaussianMixtureExample.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125992
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125902
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125785
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125752
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125728
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125610
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125532
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaGaussianMixtureExample.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125508
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaGaussianMixtureExample.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125365
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaGaussianMixtureExample.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63125262
--- Diff: docs/ml-clustering.md ---
@@ -148,5 +148,89 @@ Refer to the [Python API
docs](api/python/pyspark.ml.html#pyspark.ml.clustering.
{%
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218916962
**[Test build #58523 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58523/consoleFull)**
for PR 12788 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218917028
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218917030
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218916227
**[Test build #58522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58522/consoleFull)**
for PR 12788 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218916300
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218916297
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218915710
**[Test build #58523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58523/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218914962
**[Test build #58522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58522/consoleFull)**
for PR 12788 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218893342
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218893524
@yanboliang @MLnick @zhengruifeng @sethah simplified the example using
kmeans data and addressed review comments.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218893339
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218893234
**[Test build #58514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58514/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218891193
**[Test build #58514 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58514/consoleFull)**
for PR 12788 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218850014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218850017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218849858
**[Test build #58512 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58512/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-218847229
**[Test build #58512 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58512/consoleFull)**
for PR 12788 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r63013787
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62573653
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62558763
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62545534
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62533303
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62516305
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62511620
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62510757
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217564581
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217564579
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217564507
**[Test build #58033 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58033/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217562871
**[Test build #58033 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58033/consoleFull)**
for PR 12788 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217562662
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217541412
@sethah @zhengruifeng @yanboliang I made changes to address comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217537902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217537899
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217537788
**[Test build #58020 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58020/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217535852
**[Test build #58020 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58020/consoleFull)**
for PR 12788 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217534939
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217534341
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217534345
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217510287
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217510291
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217510152
**[Test build #58009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58009/consoleFull)**
for PR 12788 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217508233
**[Test build #58009 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58009/consoleFull)**
for PR 12788 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62185787
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-217064788
@sethah It seems that these examples follow `ml.kmeans`'s examples.
I agreed that it's better to keep in line with mllib's, especially the
output information.
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62123024
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62112629
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-216998669
I made a pass. @zhengruifeng can you please take a look as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62111999
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,78 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62111714
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,78 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62111055
--- Diff: examples/src/main/python/ml/gaussian_mixture_example.py ---
@@ -0,0 +1,78 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62108840
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaGaussianMixtureExample.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62108259
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62105335
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/GaussianMixtureExample.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12788#discussion_r62104674
--- Diff: docs/ml-clustering.md ---
@@ -104,4 +104,89 @@ Refer to the [Java API
docs](api/java/org/apache/spark/ml/clustering/LDA.html) f
{%
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-215999406
cc @yanboliang @jkbradley @MLnick @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-215888142
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-215888045
**[Test build #57363 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57363/consoleFull)**
for PR 12788 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-215888145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12788#issuecomment-215886330
**[Test build #57363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57363/consoleFull)**
for PR 12788 at commit
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/12788
[SPARK-14434][ML]:User guide doc and examples for GaussianMixture in
spark.ml
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
91 matches
Mail list logo
