[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-208435147 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207946829 **[Test build #55473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55473/consoleFull)** for PR 12274 at commit

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207946845 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207946844 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207946431 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207946430 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207946406 **[Test build #55472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55472/consoleFull)** for PR 12274 at commit

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207942146 **[Test build #55473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55473/consoleFull)** for PR 12274 at commit

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207942061 @jaceklaskowski Thanks for reviewing! I updated since versions and removed unused imports. The return type should remain `DataFrame`, i.e., `Dataset[Row]`, which is

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207941949 **[Test build #55472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55472/consoleFull)** for PR 12274 at commit

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/12274#discussion_r59124622 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala --- @@ -32,7 +32,7 @@ import

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/12274#discussion_r59124613 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/impl/GLMRegressionModel.scala --- @@ -23,7 +23,7 @@ import

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/12274#discussion_r59124592 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -171,18 +171,18 @@ abstract class PredictionModel[FeaturesType, M <:

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/12274#discussion_r59124562 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala --- @@ -124,7 +124,7 @@ class Pipeline @Since("1.4.0") ( * @return fitted

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207881183 High level change LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207841317 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207841290 **[Test build #55440 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55440/consoleFull)** for PR 12274 at commit

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207841319 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14500] [ML] Accept Dataset[_] instead o...

2016-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12274#issuecomment-207833702 **[Test build #55440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55440/consoleFull)** for PR 12274 at commit