Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217390333
Weird, is that a scala 2.10 vs 2.11 thing? some other implicit conversions
are available by default in 2.11?
---
If your project is set up for it, you can reply to
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217312688
I fixed it in
https://github.com/apache/spark/commit/7f5922aa4a810a0b9cc783956a8b7aa3dad86a0a.
I'm puzzled as to how it passed tests here?
---
If your project is
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217312115
This patch seems to have broken Spark build -
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12928
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217309796
Looks good, pretty straightforward. Merging into master 2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217308577
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217308579
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217308403
**[Test build #57924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57924/consoleFull)**
for PR 12928 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217286317
**[Test build #57924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57924/consoleFull)**
for PR 12928 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217285787
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62176096
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -98,13 +97,12 @@ private[spark] class Pool(
}
override def
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62170912
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -98,13 +97,12 @@ private[spark] class Pool(
}
override
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62170731
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -168,7 +168,7 @@ private[spark] class Client(
val appContext =
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62170253
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -168,7 +168,7 @@ private[spark] class Client(
val appContext
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62169812
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -155,10 +155,10 @@ private[spark] class Client(
// Get
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62169130
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -98,13 +97,12 @@ private[spark] class Pool(
}
override def
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62168794
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -168,7 +168,7 @@ private[spark] class Client(
val appContext =
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62168705
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
@@ -125,7 +128,7 @@ object Checkpoint extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62168766
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -155,10 +155,10 @@ private[spark] class Client(
// Get a new
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12928#issuecomment-217117345
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/12928
[SPARK-15152][DOC][MINOR] Scaladoc and Code style Improvements
## What changes were proposed in this pull request?
Minor doc and code style fixes
## How was this patch
21 matches
Mail list logo
