[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222602457 cc @jkbradley / @mengxr are we ok with changing the API? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222343969 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222343970 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222343951 **[Test build #59578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59578/consoleFull)** for PR 13380 at commit

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222341365 **[Test build #59578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59578/consoleFull)** for PR 13380 at commit

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13380#discussion_r64997106 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -48,7 +48,7 @@ class BroadcastJoinSuite extends

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13380#discussion_r64997103 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -48,7 +48,7 @@ class BroadcastJoinSuite

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13380#discussion_r64997097 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -48,7 +48,7 @@ class BroadcastJoinSuite

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13380#discussion_r64996988 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -48,7 +48,7 @@ class BroadcastJoinSuite extends

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13380#discussion_r64996971 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -48,7 +48,7 @@ class BroadcastJoinSuite

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13380#discussion_r64996960 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -48,7 +48,7 @@ class BroadcastJoinSuite

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222337714 @dongjoon-hyun Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222337348 Hi, @gatorsmile . Personally, I love this PR. :) I just hesitated to change the function signatures of MLLIB in #13352 . --- If your project is set up

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222335661 @dongjoon-hyun @andrewor14 This PR removes `SQLContext` from `MLlib`. Let me know if we should keep it. Thanks! --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222328340 @rxin `SQLContext` is not being used in the `MLlib` test suites. Thus, this PR is just to use the latest `SparkSession` to replace the existing `SQLContext` in

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222318813 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222318814 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222318770 **[Test build #59562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59562/consoleFull)** for PR 13380 at commit

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13380#issuecomment-222313642 **[Test build #59562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59562/consoleFull)** for PR 13380 at commit

[GitHub] spark pull request: [SPARK-15644] [MLlib] [SQL] Replace SQLContext...

2016-05-28 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13380 [SPARK-15644] [MLlib] [SQL] Replace SQLContext with SparkSession in MLlib What changes were proposed in this pull request? This PR is to use the latest `SparkSession` to replace the