[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-56238499 I think that Jenkins might have crashed or restarted overnight, but it seems to be working now. This looks good to me, so I'm going to merge it. Feel free to

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-56124864 Sorry for not reviewing this until now; it sort of fell off my radar. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-18 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2305#discussion_r17765356 --- Diff: docs/programming-guide.md --- @@ -286,7 +286,7 @@ We describe operations on distributed datasets later on. /div -One

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-18 Thread mattf
Github user mattf commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-56125812 thanks for the feedback. i've changed the language to be more inline with your suggestion. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-56126150 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20567/consoleFull) for PR 2305 at commit

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-56128662 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20567/consoleFull) for PR 2305 at commit

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-18 Thread mattf
Github user mattf commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-56130009 This patch fails unit tests. i'm getting HTTP 503 from jenkins, but i'm gonna go out on a limb and say this doc change didn't break the unit tests. --- If your

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-11 Thread mattf
Github user mattf commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-55256738 @JoshRosen will you take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread mattf
GitHub user mattf opened a pull request: https://github.com/apache/spark/pull/2299 [SPARK-1701] Clarify slice vs partition in the programming guide This is a partial solution to SPARK-1701, only addressing the documentation confusion. Additional work can be to actually

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2299#issuecomment-54712599 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19912/consoleFull) for PR 2299 at commit

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2299#issuecomment-54714137 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19912/consoleFull) for PR 2299 at commit

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread mattf
Github user mattf commented on the pull request: https://github.com/apache/spark/pull/2299#issuecomment-54714295 This patch fails unit tests. the failures are in the kafka tests and unrelated to this patch --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread mattf
Github user mattf closed the pull request at: https://github.com/apache/spark/pull/2299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread mattf
GitHub user mattf opened a pull request: https://github.com/apache/spark/pull/2305 [SPARK-1701] Clarify slice vs partition in the programming guide This is a partial solution to SPARK-1701, only addressing the documentation confusion. Additional work can be to actually

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread mattf
Github user mattf commented on the pull request: https://github.com/apache/spark/pull/2299#issuecomment-54723659 oops, i didn't realize renaming my branch would close this PR. i'll open another. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-54724156 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19920/consoleFull) for PR 2305 at commit

[GitHub] spark pull request: [SPARK-1701] Clarify slice vs partition in the...

2014-09-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2305#issuecomment-54726088 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19920/consoleFull) for PR 2305 at commit