[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-19 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56140430 Thanks! Merged into master and branch-1.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1903 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-18 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56004578 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56004870 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20532/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56009542 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20532/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-18 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56082379 Unrelated failure in Streaming. Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56083212 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20546/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-56091645 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20546/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-17 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55937556 Your doc update made me realize that now that we're taking a mergeFunc in ShippableVertexPartition.initFrom, it's not ideal to use the iterator concatenation approach

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-17 Thread larryxiao
Github user larryxiao commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55985270 Thanks Ankur! I learn something :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread larryxiao
Github user larryxiao commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55714900 As described in commit message: a copy of vertices with defaultVal is created before, and it's b in (a, b) = b see in

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55718184 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55718245 Yeah, a note about that default would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55718541 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20378/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55725153 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20378/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55725506 This looks good! I'll merge it pending the doc update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55831449 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20434/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-55836255 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20434/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-54694479 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-02 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-54241932 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-54242231 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19618/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-54242289 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19618/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-02 Thread ankurdave
Github user ankurdave commented on a diff in the pull request: https://github.com/apache/spark/pull/1903#discussion_r17028039 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/impl/ShippableVertexPartition.scala --- @@ -36,17 +36,27 @@ private[graphx] object

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-54243879 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19623/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-54247107 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19623/consoleFull) for PR 1903 at commit

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-08-18 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-52587969 This looks good! A test would be good too. VertexRDDSuite seems like the right place, since nothing else actually calls this variant of VertexRDD.apply. It should be

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-08-15 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-52378594 This isn't quite the right approach, since the call to reduceByKey will result in two rounds of communication and hash aggregations (in reduceByKey and

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-08-15 Thread larryxiao
Github user larryxiao commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-52381062 Thanks I can do it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-08-12 Thread larryxiao
GitHub user larryxiao opened a pull request: https://github.com/apache/spark/pull/1903 [SPARK-2062][GraphX] VertexRDD.apply does not use the mergeFunc create verticesDeduplicate with reduceByKey, using mergeFunc then proceed with verticesDedup But this is not tested and

[GitHub] spark pull request: [SPARK-2062][GraphX] VertexRDD.apply does not ...

2014-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1903#issuecomment-51887950 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your