Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-112260579
@justmytwospence yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user justmytwospence commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-112235776
Is this feature limited to equi-joins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93613197
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93569492
I manually fixed the conflicts while merging to master. Thanks! I'm
excited to test out the performance of this new feature :)
---
If your project is set up for it,
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395998
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -87,7 +126,12 @@ case class Exchange(newPartitioning:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93219080
[Test build #30319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30319/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93219524
[Test build #30319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30319/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93219531
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93220011
[Test build #30321 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30321/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93224019
[Test build #30304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30304/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93224051
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395272
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -102,6 +106,8 @@ case class Limit(limit: Int, child: SparkPlan)
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395453
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93215769
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93215758
[Test build #30309 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30309/consoleFull)
for PR 5208 at commit
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28396071
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -87,7 +126,12 @@ case class Exchange(newPartitioning:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93213692
[Test build #30315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30315/consoleFull)
for PR 5208 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395922
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28396290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93218835
[Test build #30315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30315/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93218845
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93257614
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93257603
[Test build #30321 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30321/consoleFull)
for PR 5208 at commit
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28302364
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -41,6 +41,15 @@ case class Project(projectList:
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28302328
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -72,6 +72,12 @@ abstract class SparkPlan extends
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28307147
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92696369
[Test build #30237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30237/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92693289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92692706
[Test build #30235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30235/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92693283
[Test build #30235 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30235/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92743653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92743572
[Test build #30237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30237/consoleFull)
for PR 5208 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28350524
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -41,6 +41,15 @@ case class Project(projectList:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93134866
[Test build #30289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30289/consoleFull)
for PR 5208 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93157431
https://github.com/adrian-wang/spark/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93164474
[Test build #30289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30289/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93164496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93130870
BTW, as I discussed with @chenghao-intel today, I think this is very close
to merging. There are a few things I'd like to clean up, but I propose I just
make a PR
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28386536
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -41,6 +41,15 @@ case class Project(projectList:
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93136064
Thanks! just in case your PR will conflict, please note that I just update
my PR.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93173575
[Test build #30299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30299/consoleFull)
for PR 5208 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93190389
@yhuai can you do another pass over `Exchange.scala`? I made several
changes.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28394950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28394599
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -120,27 +161,34 @@ case class Exchange(newPartitioning: Partitioning,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93205970
[Test build #30309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30309/consoleFull)
for PR 5208 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28394994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28394224
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -51,6 +51,8 @@ class JoinSuite extends QueryTest with BeforeAndAfterEach
{
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93189576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93189565
[Test build #30299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30299/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-93194500
[Test build #30304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30304/consoleFull)
for PR 5208 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28394315
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -91,6 +94,16 @@ class JoinSuite extends QueryTest with
BeforeAndAfterEach {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28394813
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -19,24 +19,39 @@ package org.apache.spark.sql.execution
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395119
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -157,28 +205,61 @@ private[sql] case class AddExchange(sqlContext:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28287371
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28287180
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -33,7 +32,11 @@ import org.apache.spark.util.MutablePair
* ::
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28286721
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -72,6 +72,12 @@ abstract class SparkPlan extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92526609
I think this is getting pretty close! If you run into trouble implementing
some of my suggestions on the `SparkPlan` interfaces for ordering please let me
know and I
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28287227
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -41,6 +41,15 @@ case class Project(projectList:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28286620
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -69,7 +72,16 @@ case class Exchange(newPartitioning: Partitioning,
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28287120
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -168,14 +190,16 @@ private[sql] case class AddExchange(sqlContext:
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28302153
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -168,14 +190,16 @@ private[sql] case class AddExchange(sqlContext:
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28302133
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -69,7 +72,16 @@ case class Exchange(newPartitioning: Partitioning,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92005142
[Test build #30109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30109/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92005254
[Test build #30110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30110/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92003179
[Test build #30107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30107/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92005296
[Test build #30107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30107/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92005298
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92006103
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92006101
[Test build #30110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30110/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92005972
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92005970
[Test build #30109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30109/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92067742
[Test build #30122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30122/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92082260
[Test build #30122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30122/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-92082262
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198836
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -72,6 +72,12 @@ abstract class SparkPlan extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198847
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -177,6 +183,7 @@ private[sql] trait LeafNode extends SparkPlan with
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala ---
@@ -60,6 +60,8 @@ case class Aggregate(
override def
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198810
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -144,6 +145,12 @@ private[sql] class SQLConf extends Serializable {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198804
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -27,6 +27,7 @@ private[spark] object SQLConf {
val COLUMN_BATCH_SIZE =
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198853
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -90,6 +90,13 @@ private[sql] abstract class SparkStrategies
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-91868560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28200329
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala ---
@@ -60,6 +60,8 @@ case class Aggregate(
override def
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-91844058
[Test build #30075 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30075/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-91868553
[Test build #30075 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30075/consoleFull)
for PR 5208 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198883
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -72,6 +72,12 @@ abstract class SparkPlan extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198903
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198910
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198929
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -162,6 +161,11 @@ private[sql] case class AddExchange(sqlContext:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198969
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-91936211
Thanks a lot for working on this! I'm very excited to have this feature.
My biggest comment is that while I like the logical separation of `ordering`
from
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28199002
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28199028
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28198938
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28200167
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28200163
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28200168
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28200178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
1 - 100 of 169 matches
Mail list logo
