GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/3668
[SPARK-2951] [PySpark] support unpickle array.array for Python 2.6 (port to
1.0)
Pyrolite can not unpickle array.array which pickled by Python 2.6, this
patch fix it by extend Pyrolite.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3668#issuecomment-66517161
[Test build #24318 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24318/consoleFull)
for PR 3668 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3668#issuecomment-66530294
[Test build #24318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24318/consoleFull)
for PR 3668 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3668#issuecomment-66530312
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3668#issuecomment-66531405
Looks like we also need to backport #1874 so that the tests can work on
Python 2.6?
---
If your project is set up for it, you can reply to this email and have your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3668#issuecomment-66535731
@davies would you mind squeezing all of that into this PR so we can fix the
build once and for all?
---
If your project is set up for it, you can reply to this email
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55582578
thanks, +1, lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55672567
LGTM Ran relevant python unit tests with no problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55685369
I'm going to merge this now.
As a reference / side note, http://bugs.python.org/issue2389 provides some
good context for why Python 2.6's array pickling
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55540972
where's the message that was sent to the pyrolite folks?
it looks like SPARK-2378 s targetted for 1.2, so it has a bit of time
---
If your project is set up for
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55540988
if you do end up merging, what do you think about logging an issue for
fixing up the workaround once pyrolite is update?
---
If your project is set up for it, you can
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-1408
I had created https://issues.apache.org/jira/browse/SPARK-3524 to track
this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55495366
Maybe we should wait a couple of days to hear back from the Pyrolite
folks and see if they will cut a new release.
+1
unless there's agreed upon urgency,
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55507864
@mattf I just found out that this is blocking #2378, which is blocking
other MLlib Python API patches, so I'm going to consider merging this now...
---
If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55470194
Maybe we should wait a couple of days to hear back from the Pyrolite folks
and see if they will cut a new release.
---
If your project is set up for it, you can reply
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2365#discussion_r17509580
--- Diff: core/src/main/scala/org/apache/spark/api/python/SerDeUtil.scala
---
@@ -28,6 +30,56 @@ import org.apache.spark.rdd.RDD
/** Utilities
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55479757
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20249/consoleFull)
for PR 2365 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55480989
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20249/consoleFull)
for PR 2365 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55345460
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/74/consoleFull)
for PR 2365 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55349565
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/74/consoleFull)
for PR 2365 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2365#issuecomment-55349723
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20181/consoleFull)
for PR 2365 at commit
22 matches
Mail list logo
