[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-11-01 Thread qiaohaijun
Github user qiaohaijun commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-61369064 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-09-12 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-55465673 Thanks, this looks good. It's really too bad we keep having to add complexity to the build to support this. For instance, I'm not sure whether it's safe in all cases to

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-09-10 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-55156821 Friendly ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-09-05 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-54679659 test this please. LGFM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-54695052 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19856/consoleFull) for PR 2141 at commit

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-54698561 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19856/consoleFull) for PR 2141 at commit

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-08-27 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-53651716 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-08-27 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-53652772 It works for me. Our dear friend `SPARK_PREPEND_CLASSES` comes alive again, thanks :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-08-26 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/2141 [SPARK-3217] Add Guava to classpath when SPARK_PREPEND_CLASSES is set. When that option is used, the compiled classes from the build directory are prepended to the classpath. Now that we avoid

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-08-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-53470528 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19225/consoleFull) for PR 2141 at commit

[GitHub] spark pull request: [SPARK-3217] Add Guava to classpath when SPARK...

2014-08-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2141#issuecomment-53476737 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19225/consoleFull) for PR 2141 at commit