Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55592767
+1 looks good. Thanks @sarutak
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55484780
@tgravescs I agree with +20, and how about asserting the priority is
between HDFS's and MR's?
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55485396
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20264/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55486586
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20264/consoleFull)
for PR 2283 at commit
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2283#discussion_r17511949
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -107,8 +103,11 @@ private[spark] class
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55493621
@tgravescs Oh, I mistook. The priority is duplicated.
Now I've modified. Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55493743
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20270/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55493835
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20271/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55493952
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20272/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55495448
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20270/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55495540
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20271/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55495663
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20272/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55513183
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20288/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55514217
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20288/consoleFull)
for PR 2283 at commit
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55409250
@sarutak can you please either upmerge or close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55411945
Thank you for notification. I've rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55412161
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20230/consoleFull)
for PR 2283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55420630
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20230/consoleFull)
for PR 2283 at commit
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55447972
thanks, can you please also address my concerns in the comment above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54589212
This change makes this shutdown hook lower than `FileSystem`'s, whereas it
used to be higher. Also does this compile for `yarn-alpha` too? Given the time
it went in, it
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54589820
@srowen It's confused but lower value is higher priority.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54589954
Ah I see. That's fine, I just wasn't sure which the intent was since I
think the original description is missing a word.
---
If your project is set up for it, you can
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54590354
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19800/consoleFull)
for PR 2283 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54590502
Ah, sorry it's my wrong. I confirm the logic of ShutdownHookManager, and
higher value is higher priority.
---
If your project is set up for it, you can reply to this
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54595905
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54602306
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54631454
Jenkins, retest this please .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54634308
I don't think this is really necessary as I see the value of the Filesystem
one as a public api now and changing its value would break compatibility, but
I'm ok with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-54587067
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19800/consoleFull)
for PR 2283 at commit
30 matches
Mail list logo
