[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread justinuang
Github user justinuang commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98541714 You can consider using set equality for the test, but other than that, it looks good! Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98541675 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98541673 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98541666 [Test build #31705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31705/consoleFull) for PR 5873 at commit

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98562704 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98562651 `set` cannot use `dict` as elements because `dict` is not hashable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5873 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98524822 [Test build #31705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31705/consoleFull) for PR 5873 at commit

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98524445 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5873#issuecomment-98524407 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7329][MLLIB] simplify ParamGridBuilder ...

2015-05-03 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/5873 [SPARK-7329][MLLIB] simplify ParamGridBuilder impl as suggested by @justinuang on #5601. You can merge this pull request into a Git repository by running: $ git pull