[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-06-01 Thread mnazario
Github user mnazario commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-107678233 We were running `pylint` on our code which was depending on pyspark. The dynamic module naming confused pylint. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-31 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-107253756 @mnazario, since this was motivated by running `pylint` checks, I'd be very curious to know whether pylint uncovered any bugs or dodgy code. Do you have any results

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-29 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106918124 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-28 Thread mnazario
Github user mnazario commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106604591 I'll remove the hack. I don't really think of the spark-submit change as a downside since it's the proper way it should be run for now. Once this stuff is moved to

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106613498 [Test build #33683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33683/consoleFull) for PR 6439 at commit

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106613086 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106613102 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106631069 [Test build #33683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33683/consoleFull) for PR 6439 at commit

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106631077 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread mnazario
GitHub user mnazario opened a pull request: https://github.com/apache/spark/pull/6439 [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql/types module conflict This PR makes the types module in `pyspark/sql/types` work with pylint static analysis by removing the dynamic naming of the

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106028240 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread justinuang
Github user justinuang commented on a diff in the pull request: https://github.com/apache/spark/pull/6439#discussion_r31166415 --- Diff: python/run-tests --- @@ -57,54 +57,54 @@ function run_test() { function run_core_tests() { echo Run core tests ... -

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread mnazario
Github user mnazario commented on a diff in the pull request: https://github.com/apache/spark/pull/6439#discussion_r31166980 --- Diff: python/run-tests --- @@ -57,54 +57,54 @@ function run_test() { function run_core_tests() { echo Run core tests ... -

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106036464 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106037153 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106037129 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106037341 [Test build #33605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33605/consoleFull) for PR 6439 at commit

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread justinuang
Github user justinuang commented on a diff in the pull request: https://github.com/apache/spark/pull/6439#discussion_r31169697 --- Diff: python/run-tests --- @@ -57,54 +57,54 @@ function run_test() { function run_core_tests() { echo Run core tests ... -

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106069260 [Test build #33605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33605/consoleFull) for PR 6439 at commit

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106084658 This looks good to me, could you also update pyspark/mllib/rand.py to random.py? (and remove the hack). One downside of this is that we can not run single test

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106069292 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106069288 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7899][PYSPARK] Fix Python 3 pyspark/sql...

2015-05-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6439#issuecomment-106074856 /cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature