Github user koertkuipers closed the pull request at:
https://github.com/apache/spark/pull/11980
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-220493938
@koertkuipers this can be closed now right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-212182404
(This is trivial but might be better if the title follows
`[SPARK-X][SQL]` format as described in
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r58319194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -120,17 +120,19 @@ object RowEncoder {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-205060651
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-205060653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-205060396
**[Test build #54809 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54809/consoleFull)**
for PR 11980 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-205046022
**[Test build #54809 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54809/consoleFull)**
for PR 11980 at commit
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57829829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -120,17 +120,19 @@ object RowEncoder {
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57829840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -680,3 +680,54 @@ case class AssertNotNull(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57827339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -680,3 +680,54 @@ case class AssertNotNull(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57827201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -120,17 +120,19 @@ object RowEncoder {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-203107239
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-203107235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-203106835
**[Test build #54457 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54457/consoleFull)**
for PR 11980 at commit
Github user koertkuipers commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-203070056
@cloud-fan i pushed at attempt at this, but i am having trouble with
RowEncoderSuite encode/decode: Product
this test uses a Product value with a StructType
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-203069529
**[Test build #54457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54457/consoleFull)**
for PR 11980 at commit
Github user koertkuipers commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-202588020
@cloud-fan i tried to do that, but i don't think i am familiar enough with
the code gen, because it breaks other unit tests. it seems to me i am messing
up with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57546554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -109,9 +109,9 @@ case class Invoke(
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-202123640
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201943853
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201943850
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201943320
**[Test build #54265 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54265/consoleFull)**
for PR 11980 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201929929
**[Test build #54265 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54265/consoleFull)**
for PR 11980 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201929262
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201929263
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201929261
**[Test build #54264 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54264/consoleFull)**
for PR 11980 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11980#issuecomment-201929188
**[Test build #54264 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54264/consoleFull)**
for PR 11980 at commit
GitHub user koertkuipers opened a pull request:
https://github.com/apache/spark/pull/11980
SPARK-14139 Dataset loses nullability in operations with RowEncoder
## What changes were proposed in this pull request?
RowEncoder now respects nullability for struct fields when
29 matches
Mail list logo
