[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55312782 @witgo Sorry, I had not realized that this had not been updated since the discussions. Just tested it, and it worked for me. LGTM --- If your project is set up for

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55352303 Ok, I am merging this over the alternative PR #1323, which is now closed. Thanks to everyone who looked at this. --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-11 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55236013 The net-net change for all of these overlapping PRs should be: remove the compiler flag, and, add the import everywhere that the warning occurs. If there are warnings

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-11 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55236678 No postfix warnings in 179ba61 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55198371 @witgo Hi, I was asked to take a look at this PR. I tested the current master vs. this PR merged with the master, and I actually found that this PR added postfix

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-10 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55210927 The code has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-10 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1330#discussion_r17401380 --- Diff: pom.xml --- @@ -839,7 +839,6 @@ arg-unchecked/arg arg-deprecation/arg arg-feature/arg -

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55213209 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20134/consoleFull) for PR 1330 at commit

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-55216430 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20134/consoleFull) for PR 1330 at commit

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-54306268 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19665/consoleFull) for PR 1330 at commit

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-54315691 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19665/consoleFull) for PR 1330 at commit

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-08-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-53340219 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-08-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-53340913 This is a sort of duplicate of https://github.com/apache/spark/pull/1069 @witgo this was opened a few times? From the discussion, I am not clear this should be

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-08-25 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-53365696 @andrewor14 , @srowen This is mainly to solve the problem of importing the scala.language.postfixOps and org.scalatest.time.SpanSugar._ at the same time. --- If

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-51070559 QA tests have started for PR 1330. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17855/consoleFull ---

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-51078602 QA results for PR 1330:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49085302 Jenkins, retest this pleae. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49085313 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49085897 QA tests have started for PR 1330. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16690/consoleFull ---

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49105352 Could you paste exactly which warnings you are eliminating? I don't see any warnings in our master jenkins build that seem relevant to these changes. --- If your

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49117596 As a result of #772. The master has fixed this problem. But we should remove this line `arg-language:postfixOps/arg` in

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49117911 QA tests have started for PR 1330. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16702/consoleFull ---

[GitHub] spark pull request: SPARK-2482: Resolve sbt warnings during build

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1330#issuecomment-49122651 QA results for PR 1330:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test