Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88725427
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88724978
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88714626
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -124,7 +147,8 @@ class KMeansModel private[ml] (
@Since("2.0.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88713108
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -414,6 +414,8 @@ object KMeans {
val RANDOM = "random"
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88722547
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -145,18 +150,67 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88713359
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -284,11 +309,26 @@ class KMeans @Since("1.5.0") (
/** @group
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88715322
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -306,6 +346,25 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88725396
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r88713635
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -284,11 +309,26 @@ class KMeans @Since("1.5.0") (
/** @group
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r84731896
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -320,6 +368,23 @@ class KMeans @Since("1.5.0") (
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83764721
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -252,8 +254,10 @@ object KMeansModel extends MLReadable[KMeansModel] {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83719858
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,6 +81,13 @@ private[clustering] trait KMeansParams extends Params
with
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83703876
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -446,6 +459,11 @@ private[ml] object DefaultParamsReader {
val cls =
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83693443
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,6 +83,14 @@ private[clustering] trait KMeansParams extends Params
with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83694799
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -446,6 +459,11 @@ private[ml] object DefaultParamsReader {
val cls =
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83694228
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83694961
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -333,13 +389,45 @@ class KMeans @Since("1.5.0") (
override def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83695311
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83662587
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -17,6 +17,8 @@
package org.apache.spark.ml.clustering
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83600176
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83599465
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83579367
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,67 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83579289
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -320,6 +362,23 @@ class KMeans @Since("1.5.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83579235
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -241,6 +252,12 @@ object KMeansModel extends MLReadable[KMeansModel] {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83579306
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -320,6 +362,23 @@ class KMeans @Since("1.5.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83521035
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -446,6 +459,11 @@ private[ml] object DefaultParamsReader {
val cls =
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83514937
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,6 +81,14 @@ private[clustering] trait KMeansParams extends Params
with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83514617
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +313,23 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83521481
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,69 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83520955
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -333,13 +384,48 @@ class KMeans @Since("1.5.0") (
override def
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83514641
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83520888
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -320,6 +354,23 @@ class KMeans @Since("1.5.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83515271
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83521550
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,69 @@ class KMeansSuite extends SparkFunSuite with
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83510194
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r83509799
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,64 @@ class KMeansSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82751668
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -446,6 +463,20 @@ private[ml] object DefaultParamsReader {
val cls =
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82753706
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82752375
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,64 @@ class KMeansSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82750575
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -333,13 +372,44 @@ class KMeans @Since("1.5.0") (
override def
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82749390
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82749322
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82749661
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,6 +81,13 @@ private[clustering] trait KMeansParams extends Params
with
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82497437
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,64 @@ class KMeansSuite extends SparkFunSuite with
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82489783
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,64 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82474666
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,64 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82474849
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +143,64 @@ class KMeansSuite extends SparkFunSuite with
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82230001
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,10 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82229991
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,10 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82215606
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,10 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82105944
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +142,53 @@ class KMeansSuite extends SparkFunSuite with
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82105608
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,10 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r82050056
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -137,18 +142,53 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r81264106
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r81263907
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r81262768
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r81262198
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80834369
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80835092
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -17,12 +17,19 @@
package org.apache.spark.ml.clustering
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80835086
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -17,12 +17,19 @@
package org.apache.spark.ml.clustering
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80835233
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -17,12 +17,19 @@
package org.apache.spark.ml.clustering
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80834115
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,10 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80833730
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80833366
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80630417
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,11 +81,23 @@ private[clustering] trait KMeansParams extends Params
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80630435
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -39,7 +40,7 @@ trait DefaultReadWriteTest extends TempDirectory {
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80630450
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80630372
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r80565861
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79957341
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,11 +81,23 @@ private[clustering] trait KMeansParams extends Params
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79958291
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +145,32 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79955766
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +146,61 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79955656
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79958476
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -22,10 +22,11 @@ import java.io.{File, IOException}
import
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79958909
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -39,7 +40,7 @@ trait DefaultReadWriteTest extends TempDirectory {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79947128
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r79936136
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -81,11 +81,23 @@ private[clustering] trait KMeansParams extends Params
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r78690235
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +146,72 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r78689714
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +322,29 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r78682701
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +322,29 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r78669003
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +322,29 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r78610830
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +145,32 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r78604875
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -203,10 +219,13 @@ object KMeansModel extends MLReadable[KMeansModel] {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77834310
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +146,61 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77758918
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -137,6 +138,17 @@ class KMeansModel private[ml] (
@Since("1.6.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77737542
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -446,6 +463,20 @@ private[ml] object DefaultParamsReader {
val cls =
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77737428
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -446,6 +463,20 @@ private[ml] object DefaultParamsReader {
val cls =
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77737335
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +146,61 @@ class KMeansSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77737026
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +322,29 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77734912
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -318,6 +327,14 @@ private[ml] object DefaultParamsWriter {
val
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77734849
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -318,6 +327,14 @@ private[ml] object DefaultParamsWriter {
val
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9#discussion_r77414688
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -139,16 +145,32 @@ class KMeansSuite extends SparkFunSuite with
93 matches
Mail list logo