[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-10-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r82267917 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -55,7 +56,7 @@ object SQLConf { val WAREHOUSE_PATH =

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-10-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r82252372 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -55,7 +56,7 @@ object SQLConf { val WAREHOUSE_PATH =

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-10-06 Thread koertkuipers
Github user koertkuipers commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r82216818 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -55,7 +56,7 @@ object SQLConf { val WAREHOUSE_PATH =

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-10-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r82154809 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -55,7 +56,7 @@ object SQLConf { val WAREHOUSE_PATH =

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13868 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-08-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r73385045 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -679,7 +680,10 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-08-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r73356981 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -111,36 +111,42 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-07-20 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r71635375 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-07-14 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r70896624 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-07-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r69648250 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-07-05 Thread avulanov
Github user avulanov commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r69644212 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-07-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r69639163 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-06-24 Thread avulanov
Github user avulanov commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r68476343 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

2016-06-24 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13868#discussion_r68441144 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with