Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93935419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,99 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93926042
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,99 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93872139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +205,26 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93872093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,104 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93871338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,104 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93871348
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,104 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93870367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,104 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93849498
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,104 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93847467
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +209,26 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93844718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +209,26 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93844582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,108 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93844573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,108 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93844552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93841229
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93841112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839843
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839797
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839460
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93839456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +57,107 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93823456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93817737
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93817572
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93817255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93817231
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93817216
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93815064
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93815041
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93815032
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814957
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,130 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814750
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -58,77 +58,126 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814713
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814699
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93814681
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93813725
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +183,72 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812285
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +183,72 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812270
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +183,72 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812259
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -133,49 +183,72 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812253
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812234
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812219
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812212
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93812197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,81 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93795379
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -287,6 +287,57 @@ public UnsafeMapData getMap(int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93795370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
---
@@ -71,6 +71,10 @@ class GenericArrayData(val array:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93792263
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -287,6 +287,57 @@ public UnsafeMapData
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93792078
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
---
@@ -71,6 +71,10 @@ class GenericArrayData(val array:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93732043
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,100 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93726522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,100 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93721954
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,100 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93720959
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,100 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93654504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,100 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93432538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,89 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r93387942
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,89 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92985372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92979265
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92979329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92972394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92915607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92545598
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92341142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92335449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92142517
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92141735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r92108007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91881499
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -57,6 +60,12 @@ public
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91881279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,33 +58,93 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91880888
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -18,8 +18,11 @@
package
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91880870
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -18,8 +18,11 @@
package
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91858221
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public BufferHolder(UnsafeRow
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91858195
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -27,6 +27,23 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91856572
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91855403
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91854826
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public BufferHolder(UnsafeRow
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91854780
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public BufferHolder(UnsafeRow
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91853950
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91039898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,28 +56,49 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91039919
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,28 +56,49 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91039873
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -59,12 +59,36 @@ trait ExpressionEvalHelper
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91039854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -132,50 +153,80 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91039840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -132,50 +153,80 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91002601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -132,50 +153,80 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91002427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -132,50 +153,80 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91002161
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -59,12 +59,36 @@ trait
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91001752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,28 +56,49 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91001488
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -56,28 +56,49 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91001362
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -50,7 +50,7 @@ object ExpressionEncoder {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r90586738
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -42,15 +42,48 @@ trait
1 - 100 of 159 matches
Mail list logo
