[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14080 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-09 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70171996 --- Diff: core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-09 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70171933 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -79,32 +89,59 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-09 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70171938 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +180,29 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-09 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70171931 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -52,6 +59,8 @@

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-09 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70171929 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -79,32 +89,59 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-09 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70171924 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +180,29 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150594 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +180,29 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150510 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -93,18 +113,34 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150439 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -79,32 +89,59 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150418 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -52,6 +59,8 @@

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150424 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -79,32 +89,59 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150386 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +180,29 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70150346 --- Diff: core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70115043 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +179,26 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70114491 --- Diff: core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70112425 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -93,18 +113,34 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70111868 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -64,6 +75,10 @@ public

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70110638 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -93,18 +113,34 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-08 Thread lovexi
Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70109683 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +179,26 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-07 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r69989978 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -93,18 +113,34 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-07 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r69989502 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +179,26 @@ private void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-07 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r69988593 --- Diff: core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-07 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r69988464 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -93,18 +113,34 @@ protected void

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-07 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r69988337 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -64,6 +75,10 @@ public

[GitHub] spark pull request #14080: [SPARK-16405] Add metrics and source for external...

2016-07-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r69981791 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +179,26 @@ private