Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r72013449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
---
@@ -45,6 +45,17 @@ case class First(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71990123
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
---
@@ -45,6 +45,17 @@ case class First(child:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71920301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child:
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71908714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71896054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child:
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71871902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child:
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71871696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child:
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/14295
[SPARK-16648][SQL] Overrides TreeNode.withNewChildren in Last
## What changes were proposed in this pull request?
Default `TreeNode.withNewChildren` implementation doesn't work for
