[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72009385 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008210 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72002405 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r71992303 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r71992270 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r71992254 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r71992242 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,13 +150,20 @@ class SimpleTestOptimizer

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r71972546 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,35 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r71971233 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,35 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/14327 [SPARK-16686][SQL] Project shouldn't be pushed down through Sample if it has new output ## What changes were proposed in this pull request? We push down `Project` through `Sample` in