[GitHub] spark pull request #14451: [SPARK-16848][SQL] Make jdbc() and read.format("j...

2017-01-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14451#discussion_r94895352 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -229,6 +229,8 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #14451: [SPARK-16848][SQL] Make jdbc() and read.format("j...

2016-08-03 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14451#discussion_r73339896 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -228,6 +228,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #14451: [SPARK-16848][SQL] Make jdbc() and read.format("j...

2016-08-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14451#discussion_r73340847 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -228,6 +228,7 @@ class DataFrameReader private[sql](sparkSession: