Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/14524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74780485
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -126,13 +126,15 @@ private[python] class PythonMLLibAPI extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74700243
--- Diff: python/pyspark/mllib/clustering.py ---
@@ -140,7 +140,7 @@ class BisectingKMeans(object):
@classmethod
@since('2.0.0')
-
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74700222
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -311,7 +311,7 @@ class HasSeed(Params):
def __init__(self):
super(HasSeed,
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74688310
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -67,7 +67,7 @@ private[shared] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74684277
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -67,7 +67,7 @@ private[shared] object SharedParamsCodeGen {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74680486
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -67,7 +67,7 @@ private[shared] object
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74159065
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -311,7 +311,7 @@ class HasSeed(Params):
def __init__(self):
super(HasSeed,
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/14524
[SPARK-16832] [ML] [WIP] CrossValidator and TrainValidationSplit are not
random without seed
## What changes were proposed in this pull request?
Default random seed for ML classes should
