[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14653 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-09-09 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14653#discussion_r78224937 --- Diff: python/pyspark/ml/wrapper.py --- @@ -19,8 +19,8 @@ from pyspark import SparkContext from pyspark.sql import DataFrame -from

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-09-09 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14653#discussion_r78224369 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -336,6 +336,11 @@ def hasParam(self, paramName): return isinstance(p, Param)

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-08-17 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/14653#discussion_r75230698 --- Diff: python/pyspark/ml/wrapper.py --- @@ -243,7 +240,7 @@ def __init__(self, java_model=None): """ Initialize this instance

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-08-17 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/14653#discussion_r75228035 --- Diff: python/pyspark/ml/classification.py --- @@ -59,6 +59,16 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredicti

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-08-17 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/14653#discussion_r75227783 --- Diff: python/pyspark/ml/classification.py --- @@ -59,6 +59,16 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredicti

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-08-17 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/14653#discussion_r75225024 --- Diff: python/pyspark/ml/classification.py --- @@ -59,6 +59,16 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredicti

[GitHub] spark pull request #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models shou...

2016-08-15 Thread evanyc15
GitHub user evanyc15 opened a pull request: https://github.com/apache/spark/pull/14653 [SPARK-10931][PYSPARK][ML] PySpark ML Models should contain Param values ## What changes were proposed in this pull request? Changed PySpark models to include the Param values. Refer