Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75773760
--- Diff: R/pkg/NAMESPACE ---
@@ -1,5 +1,9 @@
# Imports from base R
-importFrom(methods, setGeneric, setMethod, setOldClass)
+# Do not
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75772452
--- Diff: R/pkg/NAMESPACE ---
@@ -1,5 +1,9 @@
# Imports from base R
-importFrom(methods, setGeneric, setMethod, setOldClass)
+# Do not include
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75772123
--- Diff: R/pkg/NAMESPACE ---
@@ -1,5 +1,9 @@
# Imports from base R
-importFrom(methods, setGeneric, setMethod, setOldClass)
+# Do not
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75741610
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3058,7 +3057,7 @@ setMethod("str",
#' @note drop since 2.0.0
setMethod("drop",
signature(x
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75720021
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3058,7 +3057,7 @@ setMethod("str",
#' @note drop since 2.0.0
setMethod("drop",
signature(x =
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75719798
--- Diff: R/pkg/NAMESPACE ---
@@ -1,5 +1,9 @@
# Imports from base R
-importFrom(methods, setGeneric, setMethod, setOldClass)
+# Do not include
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75719536
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3058,7 +3057,7 @@ setMethod("str",
#' @note drop since 2.0.0
setMethod("drop",
signature(x =
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75718809
--- Diff: R/pkg/R/generics.R ---
@@ -1339,7 +1339,6 @@ setGeneric("spark.naiveBayes", function(data,
formula, ...) { standardGeneric("s
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75718694
--- Diff: R/pkg/R/generics.R ---
@@ -1339,7 +1339,6 @@ setGeneric("spark.naiveBayes", function(data,
formula, ...) { standardGeneric("s
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75718243
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3058,7 +3057,7 @@ setMethod("str",
#' @note drop since 2.0.0
setMethod("drop",
signature(x =
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14734#discussion_r75717898
--- Diff: R/pkg/NAMESPACE ---
@@ -1,5 +1,9 @@
# Imports from base R
-importFrom(methods, setGeneric, setMethod, setOldClass)
+# Do not include
12 matches
Mail list logo