Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15009
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r122064689
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r122050475
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r122049171
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r119739122
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r119738802
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r119739434
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildThreadAppHandle.java ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r119739413
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildThreadAppHandle.java ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r119739060
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r117548947
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,37 @@ public void testChildProcLauncher() throws
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r115573484
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,6 +183,26 @@ public void testChildProcLauncher() throws
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114852019
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,6 +183,26 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114173064
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +192,69 @@ class YarnClusterSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114173041
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -162,29 +172,10 @@ class YarnClusterSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114172443
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -467,6 +510,27 @@ public Process launch() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114173083
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +192,69 @@ class YarnClusterSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114171426
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,6 +183,26 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114172337
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -459,6 +500,8 @@ public SparkLauncher redirectToLog(String loggerName)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114170100
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -24,6 +24,7 @@ import java.security.PrivilegedExceptionAction
import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114172852
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala
---
@@ -66,6 +66,7 @@ abstract class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114172209
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +119,35 @@ public static void setConfig(String name, String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114172563
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +552,24 @@ public Process launch() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114173117
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +192,69 @@ class YarnClusterSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114172292
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -459,6 +500,8 @@ public SparkLauncher redirectToLog(String loggerName)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r114173131
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +192,69 @@ class YarnClusterSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113092246
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -95,7 +95,8 @@ public boolean isFinal() {
void kill();
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113086978
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/launcher/YarnCommandBuilderUtils.scala
---
@@ -17,10 +17,11 @@
package
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113086177
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,6 +183,28 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113086519
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +549,24 @@ public Process launch() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113085844
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -725,9 +722,15 @@ object SparkSubmit extends CommandLineUtils {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113086407
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +119,34 @@ public static void setConfig(String name, String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113086469
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +119,34 @@ public static void setConfig(String name, String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113086823
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -21,12 +21,14 @@
*
* This library allows applications to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113087052
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +192,71 @@ class YarnClusterSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113085569
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -95,7 +95,8 @@ public boolean isFinal() {
void kill();
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r112597680
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -95,7 +95,8 @@ public boolean isFinal() {
void kill();
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111222050
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r11119
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111222319
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111229901
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -58,14 +58,24 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111225286
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -720,7 +717,24 @@ object SparkSubmit extends CommandLineUtils {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111223894
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111225202
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -720,7 +717,24 @@ object SparkSubmit extends CommandLineUtils {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111221734
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111227451
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +549,22 @@ public Process launch() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111228432
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitRunner.java ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111229344
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +51,35 @@
*
*
*
+ * Here is example of
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108802255
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108801550
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108787870
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +584,45 @@ public SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108786698
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -175,6 +175,33 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108785772
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108788606
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
---
@@ -355,5 +356,4 @@ package object config {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108788237
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -55,17 +55,28 @@ import org.apache.spark.internal.config._
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108788570
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.deploy.yarn
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108786329
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -175,6 +175,33 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108788153
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +51,35 @@
*
*
*
+ * Here is example of
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108780813
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r107508739
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r107498853
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +210,152 @@ class YarnClusterSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106258149
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106243822
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +119,30 @@ public static void setConfig(String name, String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106243726
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +119,30 @@ public static void setConfig(String name, String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234262
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +579,42 @@ public SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106231320
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -175,6 +175,37 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106237826
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +210,152 @@ class YarnClusterSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106237211
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -201,6 +210,152 @@ class YarnClusterSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106230295
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,35 +17,60 @@
package org.apache.spark.launcher
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234437
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +579,42 @@ public SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106233804
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -95,7 +95,8 @@ public boolean isFinal() {
void kill();
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234552
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +579,42 @@ public SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106235524
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -46,32 +46,49 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106236076
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -46,32 +46,49 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106232474
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -175,6 +175,37 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106230692
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,35 +17,60 @@
package org.apache.spark.launcher
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106235086
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +51,35 @@
*
*
*
+ * Here is example of
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106235308
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +51,35 @@
*
*
*
+ * Here is example of
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234167
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +545,21 @@ public Process launch() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106236820
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -73,6 +74,12 @@
/** Logger name to use when launching a child
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234319
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +579,42 @@ public SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106228378
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +716,24 @@ object SparkSubmit extends CommandLineUtils {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106231404
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -175,6 +175,37 @@ public void testChildProcLauncher() throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106230108
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,35 +17,60 @@
package org.apache.spark.launcher
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106235150
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +51,35 @@
*
*
*
+ * Here is example of
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106229186
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106080005
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -252,20 +307,55 @@ class YarnClusterSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106049395
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -252,20 +307,55 @@ class YarnClusterSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106049046
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -226,6 +243,44 @@ class YarnClusterSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105261723
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +716,24 @@ object SparkSubmit extends CommandLineUtils {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105259983
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +716,24 @@ object SparkSubmit extends CommandLineUtils {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105267721
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
---
@@ -349,4 +350,8 @@ package object config {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105260515
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +716,24 @@ object SparkSubmit extends CommandLineUtils {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105261284
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
}
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105273069
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -193,6 +193,74 @@ class YarnClusterSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105282085
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
---
@@ -193,6 +193,74 @@ class YarnClusterSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105266591
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -100,6 +100,8 @@ public boolean isFinal() {
/**
*
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r104743802
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -174,6 +174,11 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r104673881
--- Diff:
examples/src/main/java/org/apache/spark/examples/JavaWordCount.java ---
@@ -36,17 +36,13 @@
public static void main(String[] args)
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r104674280
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -78,9 +78,9 @@
public static final String
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r104673708
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,13 +716,17 @@ object SparkSubmit extends CommandLineUtils {
1 - 100 of 241 matches
Mail list logo
