Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r113021061
--- Diff: docs/graphx-programming-guide.md ---
@@ -709,7 +709,8 @@ messages remaining.
The following is the type signature of the [Pregel
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r113016353
--- Diff: docs/graphx-programming-guide.md ---
@@ -709,7 +709,8 @@ messages remaining.
The following is the type signature of the [Pregel
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112821540
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,9 +708,8 @@ messages remaining.
> messaging function. These constraints allow additional
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112321864
--- Diff:
core/src/main/scala/org/apache/spark/util/PeriodicCheckpointer.scala ---
@@ -128,6 +128,16 @@ private[mllib] abstract class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112311178
--- Diff:
core/src/main/scala/org/apache/spark/util/PeriodicCheckpointer.scala ---
@@ -128,6 +128,16 @@ private[mllib] abstract class
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112108440
--- Diff:
core/src/main/scala/org/apache/spark/util/PeriodicCheckpointer.scala ---
@@ -128,6 +128,16 @@ private[mllib] abstract class
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112108549
--- Diff:
core/src/main/scala/org/apache/spark/util/PeriodicRDDCheckpointer.scala ---
@@ -15,7 +15,7 @@
* limitations under the License.
*/
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112108759
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -122,27 +125,39 @@ object Pregel extends Logging {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112108958
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +87,10 @@ private[mllib] class
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r103516676
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r103509816
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102897015
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102294384
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102292537
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -122,27 +125,39 @@ object Pregel extends Logging {
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102290972
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102168380
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102067500
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102065803
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -154,7 +169,9 @@ object Pregel extends Logging {
// count the
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102057156
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102056438
--- Diff: docs/graphx-programming-guide.md ---
@@ -708,7 +708,9 @@ messages remaining.
> messaging function. These constraints allow additional
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r102053462
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -154,7 +169,9 @@ object Pregel extends Logging {
// count the
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101952678
--- Diff: docs/graphx-programming-guide.md ---
@@ -720,25 +722,53 @@ class GraphOps[VD, ED] {
sendMsg: EdgeTriplet[VD, ED] => Iterator[(VertexId,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101950972
--- Diff: docs/graphx-programming-guide.md ---
@@ -720,25 +722,53 @@ class GraphOps[VD, ED] {
sendMsg: EdgeTriplet[VD, ED] => Iterator[(VertexId,
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101938997
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -122,27 +125,39 @@ object Pregel extends Logging {
require(maxIterations
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101882898
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -122,27 +125,39 @@ object Pregel extends Logging {
require(maxIterations
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101838127
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -155,6 +169,8 @@ object Pregel extends Logging {
i += 1
}
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101828986
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -362,12 +362,14 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Graph[VD,
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101827588
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -362,12 +362,14 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Graph[VD,
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101823330
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -155,6 +169,8 @@ object Pregel extends Logging {
i += 1
}
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101822138
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -362,12 +362,14 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Graph[VD,
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101819321
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +87,10 @@ private[mllib] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101818789
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -362,12 +362,14 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687644
--- Diff: project/MimaExcludes.scala ---
@@ -943,7 +948,7 @@ object MimaExcludes {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687206
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +87,10 @@ private[mllib] class
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687030
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -362,12 +362,14 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687075
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -122,27 +126,37 @@ object Pregel extends Logging {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687037
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -113,7 +116,8 @@ object Pregel extends Logging {
(graph: Graph[VD,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101686985
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -362,12 +362,14 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687170
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -155,6 +169,8 @@ object Pregel extends Logging {
i += 1
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687092
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -155,6 +169,8 @@ object Pregel extends Logging {
i += 1
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101687268
--- Diff: project/MimaExcludes.scala ---
@@ -943,7 +948,7 @@ object MimaExcludes {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r101216945
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -155,6 +169,8 @@ object Pregel extends Logging {
i += 1
}
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100680651
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user dding3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100680648
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100641170
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +88,7 @@ private[mllib] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100640256
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100638292
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100638130
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -76,7 +77,7 @@ import
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100632148
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/impl/PeriodicRDDCheckpointerSuite.scala
---
@@ -23,7 +23,7 @@ import org.apache.spark.{SparkContext,
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100631975
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/impl/PeriodicGraphCheckpointerSuite.scala
---
@@ -21,6 +21,7 @@ import org.apache.hadoop.fs.Path
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100612840
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100609529
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100608839
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100486931
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100486741
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100486268
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +88,7 @@ private[mllib] class
GitHub user dding3 opened a pull request:
https://github.com/apache/spark/pull/15125
[SPARK-5484][GraphX] Periodically do checkpoint in Pregel
## What changes were proposed in this pull request?
Pregel-based iterative algorithms with more than ~50 iterations begin to
slow down
58 matches
Mail list logo
