[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82683704 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,9 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82679357 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,9 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82678685 --- Diff: project/MimaExcludes.scala --- @@ -55,7 +55,11 @@ object MimaExcludes {

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82670700 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,9 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82645595 --- Diff: project/MimaExcludes.scala --- @@ -55,7 +55,11 @@ object MimaExcludes {

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82559538 --- Diff: project/MimaExcludes.scala --- @@ -55,7 +55,11 @@ object MimaExcludes {

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82544528 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,9 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82528765 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,7 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82521001 --- Diff: project/MimaExcludes.scala --- @@ -55,7 +55,11 @@ object MimaExcludes {

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82521015 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -444,7 +444,7 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-08 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82509108 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -326,36 +324,13 @@ private[spark] object TaskMetrics extends Logging {

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82500617 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -326,36 +324,13 @@ private[spark] object TaskMetrics extends Logging {

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-07 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82488439 --- Diff: project/MimaExcludes.scala --- @@ -833,6 +833,11 @@ object MimaExcludes { // [SPARK-12221] Add CPU time to metrics

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-07 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82488129 --- Diff: project/MimaExcludes.scala --- @@ -833,6 +833,11 @@ object MimaExcludes { // [SPARK-12221] Add CPU time to metrics

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-07 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82470766 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -344,15 +338,20 @@ private[spark] class BlockStatusesAccumulator

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-07 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82468147 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -344,15 +338,20 @@ private[spark] class BlockStatusesAccumulator

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-07 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82467368 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -344,15 +338,20 @@ private[spark] class BlockStatusesAccumulator

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82336487 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -281,7 +281,7 @@ private[spark] object JsonProtocol { ("Finish Time" ->

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-06 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82309886 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -281,7 +281,7 @@ private[spark] object JsonProtocol { ("Finish Time" ->