[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15433#discussion_r83043023 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -263,18 +264,19 @@ private[r] object JVMObjectTracker { //

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15433#discussion_r82961129 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -263,18 +264,19 @@ private[r] object JVMObjectTracker { //

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15433#discussion_r82960952 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -263,18 +264,19 @@ private[r] object JVMObjectTracker { //

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15433#discussion_r82960799 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -284,7 +286,7 @@ private[r] object JVMObjectTracker { objId

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread techaddict
GitHub user techaddict reopened a pull request: https://github.com/apache/spark/pull/15433 [SPARK-17822] Use weak reference in JVMObjectTracker.objMap because it may leak JVM objects ## What changes were proposed in this pull request? Use weak reference in

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread techaddict
Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/15433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-11 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/15433 [SPARK-17822] Use weak reference in JVMObjectTracker.objMap because it may leak JVM objects ## What changes were proposed in this pull request? Use weak reference in JVMObjectTracker.objMap