Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15544
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r140140577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r140131809
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r140129058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139917384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139909208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139898372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139896879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139890936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139888528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139887066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139886249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139878051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139877802
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139877421
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139876729
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139876548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,235 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139859176
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,206 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139713569
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,206
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139713018
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,206
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139710680
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,206
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139658798
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,207 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139600676
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,207
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139600490
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervalsSuite.scala
---
@@ -0,0 +1,207
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139599361
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,232 @@
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139327658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,248 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139188790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,248 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139190161
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,248 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139190528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -0,0 +1,248 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r139188326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -270,6 +270,7 @@ object FunctionRegistry {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r138779799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/HyperLogLogPlusPlusHelper.scala
---
@@ -0,0 +1,373 @@
+/*
+ * Licensed to
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r138541717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/HyperLogLogPlusPlusHelper.scala
---
@@ -0,0 +1,373 @@
+/*
+ * Licensed to
GitHub user wzhfy reopened a pull request:
https://github.com/apache/spark/pull/15544
[SPARK-17997] [SQL] Add an aggregation function for counting distinct
values for multiple intervals
## What changes were proposed in this pull request?
This work is a part of
Github user wzhfy closed the pull request at:
https://github.com/apache/spark/pull/15544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r84006557
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -142,319 +84,37 @@ case class
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r83997249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -142,319 +84,37 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r83993309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -142,319 +84,37 @@ case class
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/15544
[SPARK-17997] [SQL] Add an aggregation function for counting distinct
values for multiple intervals
## What changes were proposed in this pull request?
This work is a part of
38 matches
Mail list logo
