[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r85638393 --- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala --- @@ -179,16 +179,15 @@ class UISuite extends SparkFunSuite { test("verify

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r85638347 --- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala --- @@ -179,16 +179,15 @@ class UISuite extends SparkFunSuite { test("verify

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r85521549 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -135,7 +133,7 @@ private[spark] class SparkUI private ( private[spark] abstract

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r85521860 --- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala --- @@ -179,16 +179,15 @@ class UISuite extends SparkFunSuite { test("verify

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-28 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r85516045 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -135,7 +133,7 @@ private[spark] class SparkUI private ( private[spark]

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-24 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r84653954 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -135,7 +133,7 @@ private[spark] class SparkUI private ( private[spark]

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-24 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r84653856 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -93,15 +91,15 @@ private[spark] class SparkUI private ( /** Stop the

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r84640931 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -135,7 +133,7 @@ private[spark] class SparkUI private ( private[spark] abstract

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15603#discussion_r84640346 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -93,15 +91,15 @@ private[spark] class SparkUI private ( /** Stop the server

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/15603 [WEBUI][MINOR] Return types in methods + cleanup ## What changes were proposed in this pull request? The main purpose of the change is to discuss the purpose of `SparkUITab` class