Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15717
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92341767
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -877,6 +877,35 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92329696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -877,6 +877,35 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92329570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -877,6 +877,35 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92120744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92119730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92118904
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92118438
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92117938
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92117893
--- Diff: sql/core/src/test/resources/sql-tests/inputs/change-column.sql ---
@@ -0,0 +1,53 @@
+-- Create the origin table
+CREATE TABLE
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92117267
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92115931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,76 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92102030
--- Diff: sql/core/src/test/resources/sql-tests/inputs/change-column.sql ---
@@ -0,0 +1,53 @@
+-- Create the origin table
+CREATE TABLE
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92101718
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92101553
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92101519
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r92100070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91980973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91979994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91978507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91977923
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91977189
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,80 @@ case class AlterTableUnsetPropertiesCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91976114
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -877,6 +877,35 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91863165
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,63 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91862255
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,63 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91862243
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,63 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91862195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,63 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91862160
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -274,6 +274,63 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91862111
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -877,6 +877,35 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91672523
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -217,6 +218,29 @@ abstract class ExternalCatalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r91672371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -217,6 +218,29 @@ abstract class ExternalCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r89375744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -273,6 +273,59 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r89374353
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -273,6 +273,59 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r89371262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala ---
@@ -74,4 +74,11 @@ case class StructField(
def
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r89053215
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -93,6 +93,8 @@ statement
SET TBLPROPERTIES
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r88794337
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -93,6 +93,8 @@ statement
SET TBLPROPERTIES
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r88794139
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
---
@@ -694,19 +694,6 @@ class DDLCommandSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r87697240
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -273,6 +273,68 @@ case class AlterTableUnsetPropertiesCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15717#discussion_r87697174
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -273,6 +273,68 @@ case class AlterTableUnsetPropertiesCommand(
39 matches
Mail list logo
