Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86695651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86691637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86691491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86689510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86659555
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -173,6 +177,34 @@ case class CreateViewCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86659535
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -173,6 +177,34 @@ case class CreateViewCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86659525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86613372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86586265
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86569498
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -462,4 +487,65 @@ class SQLViewSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86497413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86494337
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -131,6 +131,26 @@ case class CreateViewCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86493888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86493863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86493730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -131,6 +131,26 @@ case class CreateViewCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86493701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -131,6 +131,26 @@ case class CreateViewCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86493685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -131,6 +131,26 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86491722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -709,10 +709,13 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86491162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86489677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/15764
[SPARK-18217] [SQL] Disallow creating permanent views based on temporary
views or UDFs
### What changes were proposed in this pull request?
Based on the discussion in
22 matches
Mail list logo
