[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87621123 --- Diff: python/pyspark/ml/feature.py --- @@ -1163,9 +1184,11 @@ class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadab

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87617539 --- Diff: python/pyspark/ml/feature.py --- @@ -158,21 +158,28 @@ class Bucketizer(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadable, Jav

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87617849 --- Diff: python/pyspark/ml/feature.py --- @@ -1163,9 +1184,11 @@ class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadab

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87593705 --- Diff: python/pyspark/ml/feature.py --- @@ -1194,21 +1217,30 @@ class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadab

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87593693 --- Diff: python/pyspark/ml/feature.py --- @@ -158,19 +158,26 @@ class Bucketizer(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadable, Jav

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87586676 --- Diff: python/pyspark/ml/feature.py --- @@ -1194,21 +1217,30 @@ class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadab

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87586787 --- Diff: python/pyspark/ml/feature.py --- @@ -1194,21 +1217,30 @@ class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadab

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r87586948 --- Diff: python/pyspark/ml/feature.py --- @@ -158,19 +158,26 @@ class Bucketizer(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadable, Jav

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspa...

2016-11-08 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/15817 [SPARK-18366][PYSPARK] Add handleInvalid to Pyspark for QuantileDiscretizer and Bucketizer ## What changes were proposed in this pull request? added the new handleInvalid param for these