Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138540329
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -0,0 +1,35 @@
+-- Test temp table
+CREATE TEMPORARY VIEW
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138539525
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,184 @@
+-- Automatically generated by
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138525087
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,184 @@
+-- Automatically generated by
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138524974
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -0,0 +1,35 @@
+-- Test temp table
+CREATE TEMPORARY VIEW
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138510770
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,74 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138505758
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,74 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r138498310
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,74 @@ case class DescribeTableCommand(
}
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16422
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r137918748
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,73 @@ case class DescribeTableCommand(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r137918691
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,73 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r127230217
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,133 @@
+-- Automatically generated by
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126386081
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,120 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126355022
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,133 @@
+-- Automatically generated by
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126354680
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,120 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126352882
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,120 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126352497
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,133 @@
+-- Automatically generated by
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126345116
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,133 @@
+-- Automatically generated by
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126344763
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,120 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126344451
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,120 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126344265
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,120 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126275817
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,133 @@
+-- Automatically generated by
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126275601
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,117 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126275587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126275554
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
@@ -0,0 +1,133 @@
+-- Automatically generated by
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126275528
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126274465
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,6 +624,117 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r126274424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125930485
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -262,7 +262,7 @@ describeFuncName
;
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125805788
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125801248
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -39,6 +39,40 @@ class SQLQuerySuite extends QueryTest with
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125800773
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -262,7 +262,7 @@ describeFuncName
;
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125692588
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -158,6 +158,27 @@ class StatisticsCollectionSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125692285
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -39,6 +39,40 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125690880
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125690472
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125689057
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -262,7 +262,7 @@ describeFuncName
;
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r125563599
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -262,7 +262,7 @@ describeFuncName
;
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r123872260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,6 +620,104 @@ case class DescribeTableCommand(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r122517212
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,6 +620,104 @@ case class DescribeTableCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r122348197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,6 +620,104 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r122348016
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,6 +620,104 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r122347812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -306,10 +306,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r122347841
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -306,10 +306,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
GitHub user wzhfy reopened a pull request:
https://github.com/apache/spark/pull/16422
[SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED table column commands
## What changes were proposed in this pull request?
Support DESC (EXTENDED | FORMATTED) ? TABLE COLUMN command.
Github user wzhfy closed the pull request at:
https://github.com/apache/spark/pull/16422
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94361604
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94357987
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94267919
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94208490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94208116
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94202748
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,100 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94202675
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94199600
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,100 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94199552
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94107668
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94107442
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94106620
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,12 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94106492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94101640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94101475
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94101445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94101427
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94101415
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -586,6 +587,122 @@ case class DescribeTableCommand(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94101398
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,12 @@ class SparkSqlAstBuilder(conf: SQLConf)
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/16422
[SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED table column commands
## What changes were proposed in this pull request?
Support DESC (EXTENDED | FORMATTED) ? TABLE COLUMN command.
65 matches
Mail list logo
