[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95871812 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95868053 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95868295 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95858028 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95869209 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,185 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95868850 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95850133 --- Diff: sql/core/src/test/resources/sql-tests/inputs/cast.sql --- @@ -0,0 +1,43 @@ +-- cast string representing a valid fractional number to

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95850028 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95717360 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,185 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95717275 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,185 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95588520 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,185 @@ public UTF8String translate(Map

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-11 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16550 [SPARK-19178][SQL] convert string of large numbers to int should return null ## What changes were proposed in this pull request? When we convert a string to integral, we will convert