Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100565585
--- Diff: docs/sql-programming-guide.md ---
@@ -1300,10 +1300,28 @@ Configuration of in-memory caching can be done
using the `setConf` method on `Sp
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100565522
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
---
@@ -44,27 +44,50 @@ trait QueryExecutionListener {
*
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100564925
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100560364
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100366124
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100236493
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100236345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100232628
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100231056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100229660
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100225242
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100224399
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100218129
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100186876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100184896
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100182956
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100127337
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100051268
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
---
@@ -44,27 +44,50 @@ trait QueryExecutionListener {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100049953
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +193,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r1981
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r1251
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99979817
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99979749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521880
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521699
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521679
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521620
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521628
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99520106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99520045
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -893,6 +896,12 @@ object SparkSession {
}
}
+
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518656
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -893,6 +896,12 @@ object SparkSession {
}
}
+
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518378
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518295
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518239
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518130
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518083
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99453252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +246,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99453218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +465,10 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99416910
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +481,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99415847
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,21 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99415540
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99415030
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,21 @@ object SQLConf {
.booleanConf
Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99414739
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +481,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99386276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99064088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +481,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99063701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,21 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99063668
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,21 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99062729
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +481,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99062659
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -261,13 +304,19 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99062495
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +246,17 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99062185
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -514,6 +576,9 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99062037
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,21 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99061828
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99061710
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99060951
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99060523
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,21 @@ object SQLConf {
.booleanConf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99032040
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -114,6 +138,55 @@ class DataFrameCallbackSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99032021
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -114,6 +138,55 @@ class DataFrameCallbackSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99032305
--- Diff: docs/sql-programming-guide.md ---
@@ -1302,8 +1302,9 @@ Configuration of in-memory caching can be done using
the `setConf` method on `Sp
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99031742
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
---
@@ -44,27 +44,49 @@ trait QueryExecutionListener {
*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r97422538
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,33 @@ final class DataFrameWriter[T] private[sql](ds:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r97422571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,33 @@ final class DataFrameWriter[T] private[sql](ds:
GitHub user salilsurendran opened a pull request:
https://github.com/apache/spark/pull/16664
[SPARK-18120 ][SQL] Call QueryExecutionListener callback methods for â¦
â¦DataFrameWriter methods
## What changes were proposed in this pull request?
QueryExecutionListener
64 matches
Mail list logo
