[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r100211955 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala --- @@ -171,4 +171,14 @@ class SQLConfEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-08 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r100089378 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala --- @@ -164,6 +164,18 @@ class SQLConfEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-08 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r100089218 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -128,6 +128,25 @@ class ConfigEntrySuite extends SparkFunSuite

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r100040758 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala --- @@ -164,6 +164,18 @@ class SQLConfEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r100040138 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -128,6 +128,25 @@ class ConfigEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-07 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r13797 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala --- @@ -164,6 +164,18 @@ class SQLConfEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-07 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r13250 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -128,6 +128,25 @@ class ConfigEntrySuite extends SparkFunSuite

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r8761 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala --- @@ -164,6 +164,18 @@ class SQLConfEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r8593 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -128,6 +128,25 @@ class ConfigEntrySuite extends

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r99979997 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala --- @@ -34,6 +34,8 @@ trait CatalystConf { def

[GitHub] spark pull request #16736: [SPARK-19265][SQL][Follow-up] Configurable `table...

2017-02-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r99979855 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -128,6 +128,21 @@ class ConfigEntrySuite extends