Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r102132903
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/ResolvedDataSourceSuite.scala
---
@@ -19,11 +19,15 @@ package org.apache.spark.sql.sources
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r102132850
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends QueryTest
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16750
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r101386663
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/ResolvedDataSourceSuite.scala
---
@@ -19,11 +19,15 @@ package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r101365748
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r101357512
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100729875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends QueryTest
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100729866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -58,13 +59,15 @@ private[sql] class JSONOptions(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100624733
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100623330
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -58,13 +59,15 @@ private[sql] class JSONOptions(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100225911
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -357,30 +361,70 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100225669
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -357,30 +361,70 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100225659
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -357,30 +361,70 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99989708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,11 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99989335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,11 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99830559
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -357,30 +361,70 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99829778
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -357,30 +361,70 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99760937
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -298,6 +299,8 @@ class DataFrameReader private[sql](sparkSession:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99760946
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,11 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99531422
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -298,6 +299,8 @@ class DataFrameReader private[sql](sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99531337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,11 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98834088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
---
@@ -161,12 +163,3 @@ private[csv] class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98834068
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -329,7 +332,17 @@ class DataFrameReader private[sql](sparkSession:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98834049
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -297,7 +300,7 @@ def text(self, paths):
def csv(self, path, schema=None, sep=None, encoding=None,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98624418
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -329,7 +332,17 @@ class DataFrameReader private[sql](sparkSession:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98629735
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -329,7 +332,17 @@ class DataFrameReader private[sql](sparkSession:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98625766
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
---
@@ -161,12 +163,3 @@ private[csv] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98623217
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -297,7 +300,7 @@ def text(self, paths):
def csv(self, path, schema=None, sep=None,
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/16750
[SPARK-18937][SQL] Timezone support in CSV/JSON parsing
## What changes were proposed in this pull request?
This is a follow-up pr of #16308.
This pr enables timezone support in
29 matches
Mail list logo