Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/16762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r104320606
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -584,24 +602,39 @@ class JoinSuite extends QueryTest with
SharedSQLContext
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r104306401
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -584,24 +602,39 @@ class JoinSuite extends QueryTest with
SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99975571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,33 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99894093
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -213,7 +213,12 @@ abstract class SparkStrategies extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99893570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,33 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99893611
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,33 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99749089
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -213,7 +213,12 @@ abstract class SparkStrategies extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99748912
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,33 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99748730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,33 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99474050
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -215,18 +215,61 @@ class JoinSuite extends QueryTest with
SharedSQLContext
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99217621
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,18 @@ case class
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r99178232
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -339,6 +340,18 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r98834480
--- Diff: sql/core/src/test/resources/sql-tests/inputs/cross-join.sql ---
@@ -33,3 +33,5 @@ create temporary view D(d, vd) as select * from nt1;
--
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r98833830
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -584,24 +602,37 @@ class JoinSuite extends QueryTest with
SharedSQLContext
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16762#discussion_r98833748
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -215,18 +215,36 @@ class JoinSuite extends QueryTest with
SharedSQLContext
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16762
[SPARK-19419] [SPARK-19420] Fix the cross join detection
### What changes were proposed in this pull request?
There are two issues in the existing detection of cartesian products.
17 matches
Mail list logo
