Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16774
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r137052323
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +113,53 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136930082
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
}
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136928086
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
}
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136926433
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +113,53 @@ class CrossValidator @Since("1.2.0")
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136868226
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +113,53 @@ class CrossValidator @Since("1.2.0")
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136719561
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -87,37 +91,63 @@ class TrainValidationSplit
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136719485
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +113,53 @@ class CrossValidator @Since("1.2.0")
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136719383
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +113,53 @@ class CrossValidator @Since("1.2.0")
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136482755
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136457345
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136456379
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136274847
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r136243309
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -120,6 +120,33 @@ class CrossValidatorSuite
}
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r111042302
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/ModelSelectionViaTrainValidationSplitExample.scala
---
@@ -65,6 +65,8 @@ object
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r111025724
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110986801
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110983267
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -121,6 +121,33 @@ class CrossValidatorSuite
}
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110981439
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110980824
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110979877
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110717717
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110713910
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110712166
--- Diff: docs/ml-tuning.md ---
@@ -55,6 +55,9 @@ for multiclass problems. The default metric used to
choose the best `ParamMap` c
method in each
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110614413
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110614311
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110614175
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -87,37 +90,64 @@ class TrainValidationSplit @Since("1.5.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110606615
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends HasSeed
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110609856
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110609667
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -121,6 +121,33 @@ class CrossValidatorSuite
}
}
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110609932
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110610484
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110609088
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110605597
--- Diff: docs/ml-tuning.md ---
@@ -55,6 +55,9 @@ for multiclass problems. The default metric used to
choose the best `ParamMap` c
method in each of
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110605449
--- Diff: docs/ml-tuning.md ---
@@ -55,6 +55,9 @@ for multiclass problems. The default metric used to
choose the best `ParamMap` c
method in each of
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110609384
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110610030
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110608787
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends HasSeed
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110605376
--- Diff: docs/ml-tuning.md ---
@@ -55,6 +55,9 @@ for multiclass problems. The default metric used to
choose the best `ParamMap` c
method in each of
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110610974
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -121,6 +121,33 @@ class CrossValidatorSuite
}
}
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110606671
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -67,6 +71,39 @@ private[ml] trait ValidatorParams extends HasSeed
Github user devesh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r103021457
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -100,31 +105,50 @@ class CrossValidator @Since("1.2.0")
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r103045855
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -121,6 +121,33 @@ class CrossValidatorSuite
}
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r101834675
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -121,6 +121,33 @@ class CrossValidatorSuite
}
44 matches
Mail list logo
