Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16787
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100681309
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -649,6 +648,16 @@ class VersionsSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100681187
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -649,6 +648,16 @@ class VersionsSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100681160
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -570,7 +570,6 @@ class VersionsSuite extends QueryTest
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100345819
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -845,10 +855,10 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100343323
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -845,10 +855,10 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100329892
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -845,10 +855,10 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100321936
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -891,7 +905,7 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100321748
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -815,7 +809,21 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100319490
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100315562
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging {
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100241493
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -776,20 +778,21 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100235734
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -815,7 +819,20 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100235680
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -776,20 +778,21 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100070021
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100059652
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100059580
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100058971
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100057282
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -583,11 +468,12 @@ private[spark] object HiveUtils extends Logging {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99470385
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -365,8 +365,8 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99462370
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -231,18 +180,17 @@ private[hive] case class MetastoreRelation(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99462090
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -815,7 +829,8 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99462031
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -815,7 +829,8 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461979
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -815,7 +829,8 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461967
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -776,7 +778,18 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461612
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461447
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461260
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461201
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99461116
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460986
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460850
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460822
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460549
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460541
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460528
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460316
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460223
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460081
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -778,6 +780,22 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99460070
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -365,8 +365,8 @@ private[hive] class HiveClientImpl(
40 matches
Mail list logo
