[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r208098556 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -119,23 +130,45 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user leachbj commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r208094538 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -119,23 +130,45 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101938630 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -287,31 +320,16 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101938607 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -108,9 +107,21 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101938559 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -119,23 +130,45 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101888508 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -119,23 +130,45 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101888059 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -287,31 +320,16 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101888000 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -108,9 +107,21 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101887954 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -119,23 +130,45 @@ object FileFormatWriter

[GitHub] spark pull request #16898: [SPARK-19563][SQL] avoid unnecessary sort in File...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r101320333 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -363,80 +393,42 @@ object FileFormatWriter