Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16910
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104309883
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1596,147 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104285450
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104275482
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1596,147 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104275500
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1596,147 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104252834
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1596,147 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104242881
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104231197
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1596,147 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104114101
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104111452
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103880490
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103864544
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103862924
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103630249
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1587,4 +1588,151 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103630036
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1587,4 +1588,151 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103416573
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,151 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103416510
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,151 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103416399
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,151 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103143687
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -83,6 +83,8 @@ class HadoopTableReader(
private val
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103143673
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -114,22 +116,34 @@ class HadoopTableReader(
val tablePath
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103134443
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -114,22 +114,30 @@ class HadoopTableReader(
val tablePath =
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102568726
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -114,22 +114,30 @@ class HadoopTableReader(
val tablePath =
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102395323
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,148 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102395141
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,148 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102394591
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,148 @@ class HiveDDLSuite
}
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102393239
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -114,22 +114,30 @@ class HadoopTableReader(
val tablePath =
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102390808
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,148 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102390174
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,148 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102389966
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,148 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102389843
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -114,22 +114,30 @@ class HadoopTableReader(
val tablePath
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102126586
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -114,22 +114,30 @@ class HadoopTableReader(
val tablePath
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102126306
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
---
@@ -139,6 +140,13 @@ case class HiveTableScanExec(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102121338
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
---
@@ -139,6 +140,13 @@ case class HiveTableScanExec(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102117217
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,149 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102077850
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
---
@@ -139,6 +140,13 @@ case class HiveTableScanExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102076358
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,149 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102076327
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,149 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102076290
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,149 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r102076227
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1494,4 +1495,149 @@ class HiveDDLSuite
}
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/16910
[SPARK-19575][SQL]Reading from or writing to a hive serde table with a non
pre-existing location should succeed
## What changes were proposed in this pull request?
This PR is a
40 matches
Mail list logo
