Github user Miro12 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16966#discussion_r112689291
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -147,6 +148,15 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/16966#discussion_r102065786
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -147,6 +148,15 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16966#discussion_r102005885
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -147,6 +148,15 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/16966#discussion_r101832855
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -147,6 +148,15 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16966#discussion_r101684524
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -147,6 +148,15 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
GitHub user Yunni opened a pull request:
https://github.com/apache/spark/pull/16966
[SPARK-18409][ML]LSH approxNearestNeighbors should use approxQuantile
instead of sort
## What changes were proposed in this pull request?
In previous implementation of LSH
