Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r106569149
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -55,7 +55,7 @@ class
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r106569064
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r106335040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r106309333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r105588823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r105588798
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -55,7 +55,7 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r105588596
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103872828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844105
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -91,7 +99,9 @@ object StatFunctions extends Logging {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844048
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -78,7 +81,12 @@ object StatFunctions extends Logging {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -176,17 +176,21 @@ class QuantileSummaries(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103843868
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -89,22 +88,17 @@ final class DataFrameStatFunctions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103270963
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -91,7 +100,13 @@ object StatFunctions extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102601793
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -89,18 +89,17 @@ final class DataFrameStatFunctions
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102592174
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -78,7 +80,12 @@ object StatFunctions extends Logging {
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102589719
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -89,18 +89,17 @@ final class DataFrameStatFunctions
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102167055
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -214,20 +214,29 @@ class DataFrameStatSuite extends QueryTest
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102146260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -78,7 +80,13 @@ object StatFunctions extends Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102145908
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -89,18 +89,17 @@ final class DataFrameStatFunctions
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102145412
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -54,6 +54,8 @@ object StatFunctions extends Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102145538
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -89,18 +89,17 @@ final class DataFrameStatFunctions
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r102146144
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -214,20 +214,29 @@ class DataFrameStatSuite extends QueryTest with
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/16971
[SPARK-19573][SQL] Make NaN/null handling consistent in approxQuantile
## What changes were proposed in this pull request?
update `StatFunctions.multipleApproxQuantiles` to handle NaN/null
25 matches
Mail list logo
