Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17185
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208089990
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208079529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -201,7 +204,7 @@ case class Alias(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208079335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -201,7 +204,7 @@ case class Alias(child:
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208078928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -794,19 +795,37 @@ case class
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208078754
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -201,7 +204,7 @@ case class Alias(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208074858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -794,19 +795,37 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208074745
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208073035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -201,7 +204,7 @@ case class Alias(child:
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208059884
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207759811
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207726267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207725519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207718090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207717569
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -316,8 +345,8 @@ case class
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207717536
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -536,12 +536,13 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207702706
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -536,12 +536,13 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207701939
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -316,8 +345,8 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207702684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207640501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207635526
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207624865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -121,14 +129,14 @@ abstract class Attribute
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207624726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -71,19 +71,27 @@ trait NamedExpression
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207105608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -71,19 +71,27 @@ trait NamedExpression
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207104518
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207104432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207104014
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207027392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -121,14 +129,14 @@ abstract class Attribute
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206988504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -120,22 +120,54 @@ abstract class LogicalPlan
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206985225
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -120,22 +120,54 @@ abstract class LogicalPlan
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206978220
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -654,16 +654,19 @@ class SessionCatalog(
*
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206975896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206382570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -120,22 +120,54 @@ abstract class LogicalPlan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206381686
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -121,14 +129,14 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206381459
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -654,16 +654,19 @@ class SessionCatalog(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206380665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r165230391
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -88,12 +88,12 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r163322810
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -88,12 +88,12 @@ case class
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r106253035
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-views.sql ---
@@ -13,10 +13,8 @@ DROP VIEW view1;
-- Test scenario with Global
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r104822673
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-views.sql ---
@@ -13,10 +13,8 @@ DROP VIEW view1;
-- Test scenario with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r104817117
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-views.sql ---
@@ -13,10 +13,8 @@ DROP VIEW view1;
-- Test scenario with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r104817091
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-views.sql ---
@@ -13,10 +13,8 @@ DROP VIEW view1;
-- Test scenario with
GitHub user skambha opened a pull request:
https://github.com/apache/spark/pull/17185
[SPARK-19602][SQL] Support column resolution of fully qualified column name
( 3 part name)
## What changes were proposed in this pull request?
The design details is attached to the JIRA issue
43 matches
Mail list logo
