[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r106577342 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -52,62 +63,79 @@ private[spark] class TaskContextImpl( @volatile

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r106363391 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -52,62 +63,79 @@ private[spark] class TaskContextImpl( @volatile

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r106318836 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -52,62 +63,79 @@ private[spark] class TaskContextImpl( @volatile

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r106318801 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -52,62 +63,79 @@ private[spark] class TaskContextImpl( @volatile

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-13 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105788774 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -126,14 +134,14 @@ abstract class TaskContext extends Serializable { }

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-13 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105780702 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -126,14 +134,14 @@ abstract class TaskContext extends Serializable { }

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-13 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105785854 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskContextSuite.scala --- @@ -228,6 +228,31 @@ class TaskContextSuite extends SparkFunSuite

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-13 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105779991 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -105,7 +105,11 @@ abstract class TaskContext extends Serializable {

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-12 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105559913 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-12 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105559906 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-12 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105559898 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-12 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105559900 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105510888 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105491214 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105490080 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105489232 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105489812 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17244#discussion_r105489927 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl( // Whether the

[GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...

2017-03-10 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/17244 [SPARK-19889][SQL] Make TaskContext callbacks thread safe ## What changes were proposed in this pull request? It is sometimes useful to use multiple threads in a task to parallelize tasks.