Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110977254
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest with
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110977330
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest with
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110976069
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -76,6 +76,13 @@ class CachedTableSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110885997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -76,6 +76,13 @@ class CachedTableSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110885627
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110885501
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest with
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110693397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -59,6 +58,13 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110671813
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -59,6 +58,13 @@ abstract class SubqueryExpression(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110671334
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -59,6 +58,13 @@ abstract class SubqueryExpression(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110671091
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -236,6 +244,12 @@ case class ScalarSubquery(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110590906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -401,8 +401,9 @@ abstract class QueryPlan[PlanType <:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110590426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -236,6 +244,12 @@ case class ScalarSubquery(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r11056
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -236,6 +244,12 @@ case class ScalarSubquery(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110587691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -401,8 +401,9 @@ abstract class QueryPlan[PlanType <:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110587292
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -59,6 +59,14 @@ abstract class SubqueryExpression(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107869502
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107713751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107659893
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107614291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class SubqueryExpression(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107494062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107395654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107343122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107332590
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107331403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class SubqueryExpression(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107077129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107070667
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class SubqueryExpression(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106884365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106866491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class SubqueryExpression(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106840346
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106838131
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class SubqueryExpression(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795788
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -655,6 +663,148 @@ class CachedTableSuite extends QueryTest with
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795750
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795294
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -655,6 +663,148 @@ class CachedTableSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression {
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17330
[SPARK-19993][SQL] Caching logical plans containing subquery expressions
does not work.
## What changes were proposed in this pull request?
The sameResult() method does not work when the
41 matches
Mail list logo
